[RESOLVED] Exiting Does Not Close PUP Packs

[Mike_da_Spike]

thanks for testing. No change indeed.

[Tom Speirs]

it closes the player first then the editor. Please see if 6.68 is any better. Uploading now.

[Mike_da_Spike]

8 hours ago, Tom Speirs said:

it closes the player first then the editor. Please see if 6.68 is any better. Uploading now.

I am experiencing unusual behavior, Tom.
When I launch Batman 66 from PinballX and either play the game or wait for a few minutes, the closure is not executed gracefully, and the process is terminated after a timeout.
However, if I simply launch the game, wait for a few seconds, and then exit, it closes promptly.

My observation was that when pressing the exit button, PinupDisplay and PinupPlayer closed almost instantly, while VPPlayer and the editor remained active until the timeout.
The VPPlayer stayed in the suspended status, even though the editor was no longer suspended after pressing exit.

the following screenshot is just taken before I press the exit button:

If I launch the same table without the front end, the 2 processes doesn't come in the suspend state. Not sure if that is causing any issue

attached is the log (I also had a PinballX crash after exiting my last table)

 

log.txt

[Tom Speirs]

okay, ill roll it back and try and give some versions for testing.

Cheers.

[Mike_da_Spike]

6.69 is most of the time 'slow'
Even when the game was just launched (which would close quickly with 6.68).
I do not see the processes in suspend mode anymore .
However, as before, PinupDisplay and PinupPlayer closed almost immediately when exit is pressed, while VPPlayer and the editor remained active until the timeout.

log.txt

[Tom Speirs]

 

i have not got any pup tables to test but give 6.70 a go.

6.70 is up. Its working on my cab but its not a fancy setup. no pup.

 

[Mike_da_Spike]

6.70 give an CRC error during unpacking :

I tried to download it multiple times, but all the versions gives this on my PC and cabinet

edit :

I noticed there was another version of 6.70, so I downloaded that one and that one didn't have the CRC error

[Mike_da_Spike]

I played a couple of Batman '66 games and some regular ones, and all completed in decent times.
The "killing processes" no longer appear in the log, and there are no open processes from Pinup Player anymore.
Nice job @Tom Speirs !

I hope this is working for @DJO Maverick as well, as it is his thread
 

log.txt

[Tom Speirs]

Thank you for your help. Download is good now.

[Tom Speirs]

I am just releasing 6.72. i notice after launching a table, PinballX won't initialise full screen exclusive in your log so I made sure it wont try again after it failed. That should shave a bit of time of. I also removed the sleep. Seems unnecessary.

[Tom Speirs]

What it basically does now is try and keep closing the windows. Here is a "test" version that tries to do that a big quicker than 6.72.

It should hopefully shave a second or two off. Please test both.

 

PinballX.7z

[Tom Speirs]

Here is another one, slightly different faster timing but it may well be closing before it tries to close again anyway as I am closing the player on a different thread to the editor. My cab is well out of date but all exits super fast.

PinballX.7z

[Mike_da_Spike]

6 hours ago, Tom Speirs said:

I am just releasing 6.72. i notice after launching a table, PinballX won't initialise full screen exclusive in your log so I made sure it wont try again after it failed. That should shave a bit of time of. I also removed the sleep. Seems unnecessary.

I fixed that issue yesterday. It was a user error. -shame-
The problem occurred because the Topper screen was enabled, but no size was specified in the INI file.
After resolving this, the errors related to Full Screen disappeared as well.
I am unable to test your files you post as I won't be at my cab for the next few days, but I hope to test it soon (thursday or friday).
Even a few seconds off might make a significant difference.

Thank you, Tom!

[scutters]

For whatever reason i didn't see 'process killed' issue and got consistent clean closes... so my tests may not be relevant, but here's my logs just launching and exiting the same table with different versions;

log666.txt

log672.txt

logTest1.txt 

logTest2.txt

(test 1 is the first version, 2 is the 2nd)

All my exits were clean and took around 2.75 secs (from exit press to backglass created log entries). One thing i noticed was that the first test version appeared not to get the high score data.

[DJO Maverick]

Tried 6.72.  Significant progress, but still a hitch.  Batman '66 and Futurama launched and closed without issue.  With VPW's Iron Maiden, it is still not closing properly.  Looks like Batman still fell back to a kill process, Futurama closed cleanly, and Iron Maiden was a timeout.

log.txt

[Tom Speirs]

Thank you for reporting back.

Glad it is better, but unfortunately I am out of other ideas right now. 

I can try just closing the editor though, or closing the player after the editor. i will get back to you.

[Mike_da_Spike]

I tested other tables (Pinbot and LOTR), and both also close slowly for me (see attached log). Additionally, I noticed that DOF does not terminate correctly, as the lights remain on.

I devised a workaround for myself (applicable only to VPinball). I locate the PID for Visual Pinball and closes the process externally from PinballX (assigned to my Stream Deck, not Steam Deck!). This method closes Visual PinballX very fast and in a prober way, ensures DOF shuts down properly, saves NVram correctly, and allows PinballX to read the high score as intended.

log.txt

[Tom Speirs]

Please try 6.73 and let me know the results.

[Tom Speirs]

I tested Lord of the rings 2.6 vpw on my cab, seems to exit works fine.

[Mike_da_Spike]

18 hours ago, Tom Speirs said:

Please try 6.73 and let me know the results.

 

18 hours ago, Tom Speirs said:

I tested Lord of the rings 2.6 vpw on my cab, seems to exit works fine.

I tested several games with the latest version: launched games, exited games, played games, and exited games again.
All of them closed swiftly and returned promptly to the front-end.
I won't celebrate too early, as we say in the Netherlands, but this looks promising, Tom.  
@DJO Maverick how is your experience on overall table closing ?

EDIT : My previous log also showed 6.73, and I downloaded latest 6.73 for this test. Should this not be 6.74 ?

log.txt

[Draco1962]

Odd. 6.73 is the latest version showing in the downloads. Maybe you downloaded it while driving a certain DeLorean? 

 

[Mike_da_Spike]

Wel it was something like that, but the car is different: 

 

 

[DJO Maverick]

Well, as much as hate to stay on the bad news train...

6.73 actually represents a regression on my end.  Last build would at least close everything except Iron Maiden reliably.  This build goes back to never closing Batman '66 PUP and timing out eventually.

log.txt

[Tom Speirs]

So none of those tables exit?

[Tom Speirs]

Please try this one. Thanks.

PinballX.zip